[Lens] Remove scss from annotations plugin, visualization-ui-components and gauge expression #208891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
added
the
release_note:skip
mbondyra
changed the title
mbondyra
changed the title
mbondyra
force-pushed
the
lens/scss-js
branch
from
d2cd1ac to
21bf098
Compare
MichaelMarcialis
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks, @mbondyra. I've left two small comments/question regarding whether we can reduce some style repetition/redundancy, but this looks good to me otherwise. Assuming you're able to address those, I'll approve now so I don't hold you up.
Comment on lines
370
to
374
| css={css` | ||
| & + .lnsRowCompressedMargin { | ||
| margin-top: ${euiThemeVars.euiSizeS}; | ||
| } | ||
| `} |
There was a problem hiding this comment.
This same style is used multiple times throughout this PR. To keep things DRY, would it be better to store this style in a separate .style.ts file and reference that one style in all locations, rather than repeating the style?
Comment on lines
65
to
68
| css: { | ||
| color: !fieldOption.compatible ? euiThemeVars.euiColorLightShade : undefined, | ||
| backgroundColor: !fieldOptionExists ? euiThemeVars.euiColorLightestShade : undefined, | ||
| }, |
There was a problem hiding this comment.
Same comment here as previous. Is there anything that can be done here to avoid repeating the same styles?
mbondyra
force-pushed
the
lens/scss-js
branch
from
21bf098 to
56d998a
Compare
nickofthyme
approved these changes
Jan 30, 2025
| } from '@elastic/eui'; | ||
| import type { DataViewBase, Query } from '@kbn/es-query'; | ||
| import { css } from '@emotion/react'; | ||
| import { euiThemeVars } from '@kbn/ui-theme'; |
There was a problem hiding this comment.
It seems like the EUI team is asking people to move away from using euiThemeVars and instead using the useEuiTheme hook. See #199715 and search for euiThemeVars.
Before:
import { EuiIcon, EuiCode, EuiText, useEuiTheme } from '@elastic/eui';
height: ${euiThemeVars.euiSizeXS} / 2;After:
import { useEuiTheme } from '@elastic/eui'
const { euiTheme } = useEuiTheme();
height: ${euiTheme.size.xs} / 2;
mbondyra
force-pushed
the
lens/scss-js
branch
from
49ec1a4 to
bf0f334
Compare
mbondyra
force-pushed
the
lens/scss-js
branch
from
2aa224f to
6e1fc08
Compare
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
part of #208908
Replaces scss to css-in-js. I've tested all the changes.